Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clio's include_deleted param in ledger_entry to fetch deleted MPT #1097

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

shawnxie999
Copy link
Collaborator

@shawnxie999 shawnxie999 commented Dec 11, 2024

High Level Overview of Change

Context of Change

Before
image

after
image
getMPTIssuance fails to fetch the MPT because the MPT itself has been deleted. Clio's ledger_entry API supports querying deleted object by specifying include_deleted to be true

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

Before / After

Test Plan

@mvadari
Copy link
Collaborator

mvadari commented Dec 12, 2024

nit: please add before/after screenshots (instead of just after)

@shawnxie999 shawnxie999 merged commit 8cdbf05 into staging Dec 12, 2024
4 checks passed
@shawnxie999 shawnxie999 deleted the show-deleted-mpt branch December 12, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants