use bigint printer when int attr exceeds uint64 range #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars-risc0
force-pushed
the
mars/print-big-rust-literals
branch
from
563f692 to
ad3928e
Compare
jacobdweightman
approved these changes
Aug 23, 2024
|
While this change is probably fine for its own sake, it arose as a downstream consequence of a problem in R1CS lowering which no longer repros, so it is no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntegerAttr's uint64 getter fails when attribute is out of range; test for that condition and use the print function instead of the stream output