Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous bug fixes #14

Merged
merged 7 commits into from
Aug 24, 2024
Merged

Miscellaneous bug fixes #14

merged 7 commits into from
Aug 24, 2024

Conversation

jacobdweightman
Copy link
Contributor

Summary:

  • Add use-once memory example
  • Generalize argument components to support more complicated structures
  • Fix bug that would illegally reuse columns when assigning concrete layouts
  • Unravel muxes with array supers when generating constraints

shkoo
shkoo approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@shkoo shkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a lot of layout calculation changes that I'm just going to assume are reasonable. :) Glad to see repro tests!

@jacobdweightman jacobdweightman force-pushed the jacob/fixes-for-iddo branch 2 times, most recently from d011f13 to 2d378c3 Compare August 24, 2024 05:05
@jacobdweightman jacobdweightman merged commit 21dbf4d into main Aug 24, 2024
7 checks passed
@jacobdweightman jacobdweightman deleted the jacob/fixes-for-iddo branch August 24, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shkoo shkoo shkoo approved these changes

@mars-risc0 mars-risc0 Awaiting requested review from mars-risc0

@iddo-bentov iddo-bentov Awaiting requested review from iddo-bentov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobdweightman @shkoo