Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unused test support function which prompts a compiler warning #21

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

mars-risc0
Copy link
Contributor

this was fixed in risczero-wip, but either didn't land or otherwise didn't make it to the zirgen repo

@mars-risc0 mars-risc0 requested review from shkoo and tzerrell August 26, 2024 18:22
@mars-risc0 mars-risc0 enabled auto-merge (squash) August 26, 2024 18:22
@shkoo
Copy link
Contributor

shkoo commented Aug 26, 2024

@tzerrell, best I can tell we get test coverage with the makeConstOneTest, so we don't need the makeConstZeroTest so this looks good to me, but please chime in if it isn't!

@shkoo shkoo disabled auto-merge August 26, 2024 18:43
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is good, this was meant to be a simpler variant that might pass when the makeConstOneTest would fail, but because the input was unnecessary it actually created more problems without testing anything relevant beyond what makeConstOneTest tests

@mars-risc0 mars-risc0 merged commit 004f942 into main Aug 26, 2024
7 checks passed
@mars-risc0 mars-risc0 deleted the mars/delete-unused-const-zero-test branch August 26, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants