Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIR-215: abstract bibc file format reader & writer for use on memory buffers #54

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

mars-risc0
Copy link
Contributor

instead of generating a tmp file, you can now read from/write to a memory buffer

@mars-risc0 mars-risc0 requested a review from jbruestle October 29, 2024 00:04
@github-actions github-actions bot changed the title abstract bibc file format reader & writer for use on memory buffers ZIR-215: abstract bibc file format reader & writer for use on memory buffers Oct 29, 2024
@mars-risc0 mars-risc0 force-pushed the mars/bibc-file-buffers branch from 234bf20 to ba22d48 Compare October 29, 2024 20:04
@mars-risc0 mars-risc0 marked this pull request as ready for review October 29, 2024 20:04
@mars-risc0 mars-risc0 force-pushed the mars/bibc-file-buffers branch from bb0be8d to da22e2f Compare October 29, 2024 20:24
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Marked one possible oversight inline.

zirgen/Dialect/BigInt/Bytecode/test/test.cpp Show resolved Hide resolved
@mars-risc0 mars-risc0 requested a review from tzerrell October 29, 2024 20:47
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mars-risc0 mars-risc0 merged commit f85ca0f into main Oct 29, 2024
8 checks passed
@mars-risc0 mars-risc0 deleted the mars/bibc-file-buffers branch October 29, 2024 21:22
iddo-bentov pushed a commit that referenced this pull request Nov 6, 2024
…buffers (#54)

* restore eval's skip-terminator behavior; bibc decoder adds expected ReturnOp

* abstract bibc file format reader & writer for use on memory buffers

* test round-trip execution identity for BIBC import & export

* clang-format

* add LowerInvPass (in addition to LowerReducePass) for future convenience
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants