rpmi: performance: Add memory region service #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lftan
reviewed
Dec 11, 2024
lftan
reviewed
Dec 11, 2024
lftan
reviewed
Dec 11, 2024
lftan
reviewed
Dec 11, 2024
lftan
reviewed
Dec 11, 2024
lftan
reviewed
Dec 11, 2024
lftan
reviewed
Dec 11, 2024
yeongjoshua
force-pushed
the
perf-memory-region
branch
from
2a28a69 to
f04b957
Compare
yeongjoshua
commented
Dec 12, 2024
yeongjoshua
force-pushed
the
perf-memory-region
branch
from
f04b957 to
0d2c4c5
Compare
lftan
reviewed
Dec 13, 2024
lftan
reviewed
Dec 13, 2024
yeongjoshua
force-pushed
the
perf-memory-region
branch
from
0d2c4c5 to
4689f53
Compare
pathakraul
reviewed
Dec 18, 2024
pathakraul
reviewed
Dec 18, 2024
pathakraul
reviewed
Dec 18, 2024
pathakraul
reviewed
Dec 18, 2024
pathakraul
reviewed
Dec 18, 2024
pathakraul
reviewed
Dec 18, 2024
pathakraul
reviewed
Dec 18, 2024
yeongjoshua
force-pushed
the
perf-memory-region
branch
from
4689f53 to
7536240
Compare
yeongjoshua
force-pushed
the
perf-memory-region
branch
from
995b1d6 to
992d6ee
Compare
pathakraul
reviewed
Dec 25, 2024
|
@pathakraul would this one is more preferred instead? |
yeongjoshua
force-pushed
the
perf-memory-region
branch
2 times, most recently
from
865aace to
fd069f8
Compare
pathakraul
reviewed
Jan 2, 2025
pathakraul
reviewed
Jan 2, 2025
pathakraul
reviewed
Jan 2, 2025
|
Apart from above i dont have any more comments. There are some minor formatting required which i will handle to make it similar to rest of the spec. |
|
Also please rebase this PR with latest main branch |
Clarify the performance level represented by the performance index which links to its attributes through PERF_GET_SUPPORTED_LEVELS. Segregate the RPMI performance fast shared region to ease PMP/SPMP on the fast channel memory region block. Signed-off-by: Joshua Yeong <[email protected]>
yeongjoshua
force-pushed
the
perf-memory-region
branch
from
fd069f8 to
06c5cb7
Compare
lftan
reviewed
Jan 6, 2025
lftan
reviewed
Jan 6, 2025
yeongjoshua
force-pushed
the
perf-memory-region
branch
2 times, most recently
from
6abb148 to
d579bb4
Compare
lftan
reviewed
Jan 6, 2025
pathakraul
reviewed
Jan 6, 2025
|
Performance group is fine. only one comment in the voltage group above |
Simplify fixed/discrete level and single/multi linear format. Signed-off-by: Joshua Yeong <[email protected]>
yeongjoshua
force-pushed
the
perf-memory-region
branch
from
d579bb4 to
eb9a17e
Compare
lftan
reviewed
Jan 8, 2025
added 2 commits
January 8, 2025 11:34
Simplify fixed/discrete level and single/multi linear format. Signed-off-by: Joshua Yeong <[email protected]>
Fix typo on clock format. Signed-off-by: Joshua Yeong <[email protected]>
yeongjoshua
force-pushed
the
perf-memory-region
branch
from
eb9a17e to
8da95d8
Compare
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'PERF_GET_FAST_CHANNEL_REGION' service to get a continuous block of physical memory region for fast channel access.