Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting PMP Granularity over CLI #1490

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Add support for setting PMP Granularity over CLI #1490

merged 1 commit into from
Nov 9, 2023

Conversation

iamkarthikbk
Copy link
Contributor

Resolves #1478

@iamkarthikbk iamkarthikbk mentioned this pull request Oct 28, 2023
Closed
@jerryz123
Copy link
Collaborator

To support bisectable commit history, this project requires that each commit in a PR pass the tests.
This project also requires that PRs be up-to-date with the master branch before merge, so you should rebase your changes on top of master, rather than merge master into your feature branch.

@iamkarthikbk iamkarthikbk reopened this Nov 3, 2023
@iamkarthikbk
Copy link
Contributor Author

Hi @jerryz123 . Now there's a single commit that should work. How should I trigger the CI workflows ?

@iamkarthikbk
Copy link
Contributor Author

Can you help me understand why the test failed? I don't think I understand it well enough to find what's broken and fix it.

scottj97
scottj97 reviewed Nov 3, 2023
View reviewed changes
spike_main/spike.cc Outdated Show resolved Hide resolved
@iamkarthikbk iamkarthikbk reopened this Nov 4, 2023
@iamkarthikbk iamkarthikbk requested a review from scottj97 November 4, 2023 10:10
@iamkarthikbk iamkarthikbk reopened this Nov 4, 2023
@iamkarthikbk
expose pmp granularity as a cli option.
5bdb9d4 
PMP Granularity is made available as a command line option. The default
value is 4 Bytes. The value can be changed by passing the option
--pmp-granularity=<value> to spike.

Signed-off-by: Karthik B K <[email protected]>
@iamkarthikbk iamkarthikbk reopened this Nov 4, 2023
@iamkarthikbk
Copy link
Contributor Author

Hi @scottj97 . Could you please review the changes now ?

@aswaterman aswaterman merged commit 5f576bd into riscv-software-src:master Nov 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman approved these changes

@scottj97 scottj97 scottj97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing PMP Grain through CLI
4 participants
@iamkarthikbk @jerryz123 @scottj97 @aswaterman