Merge pull request #20 from risgk/develop

v2.0.1
risgk · Jan 5, 2024 · 3462256 · 3462256
2 parents 9b08411 + 467365e
commit 3462256
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 21 deletions.
diff --git a/Digital-Synth-PRA32-U/pra32-u-delay-fx.h b/Digital-Synth-PRA32-U/pra32-u-delay-fx.h
@@ -88,8 +88,8 @@ class PRA32_U_DelayFx {
     if (m_delay_mode >= 64) {
 #endif
       // Ping Pong Delay
-      left_feedback  = ((                                    right_delay) * m_delay_feedback_effective) / 256;
-      right_feedback = ((((left_input + right_input) >> 2) + left_delay ) * m_delay_feedback_effective) / 256;
+      left_feedback  = ((((left_input + right_input) >> 2) + right_delay) * m_delay_feedback_effective) / 256;
+      right_feedback = ((                                    left_delay ) * m_delay_feedback_effective) / 256;
     } else {
       // Stereo Delay
       left_feedback  = ((((left_input  >> 1) + left_delay ) * m_delay_feedback_effective) / 256);

diff --git a/PRA32-U-MIDI-Implementation-Chart.md b/PRA32-U-MIDI-Implementation-Chart.md
@@ -1,6 +1,6 @@
 ```
-  [Polyphonic/Paraphonic Synthesizer]                             Date: 2024-01-04                     
-  Model: Digital Synth PRA32-U    MIDI Implementation Chart       Version: 2.0.0                       
+  [Polyphonic/Paraphonic Synthesizer]                             Date: 2024-01-05                     
+  Model: Digital Synth PRA32-U    MIDI Implementation Chart       Version: 2.0.1                       
 +-------------------------------+---------------+---------------+-------------------------------------+
 | Function...                   | Transmitted   | Recognized    | Remarks                             |
 +-------------------------------+---------------+---------------+-------------------------------------+

diff --git a/PRA32-U-Parameter-Guide.md b/PRA32-U-Parameter-Guide.md
@@ -1,6 +1,6 @@
-# Digital Synth PRA32-U Parameter Guide v2.0.0
+# Digital Synth PRA32-U Parameter Guide v2.0.1
 
-- 2024-01-04 ISGK Instruments
+- 2024-01-05 ISGK Instruments
 - <https://github.com/risgk/digital-synth-pra32-u>
 
 ## Control Change Parameters
@@ -64,14 +64,21 @@
     - 121: f = 14080 kHz
     - 127: f = 19912.1 Hz (max)
 - Filter Resonance
-    - 16 (0-23): Q = 0.7 (min)
-    - 32 (24-39): Q = 1.0
-    - 48 (40-55): Q = 1.4
-    - 64 (56-71): Q = 2.0
-    - 80 (72-87): Q = 2.8
-    - 96 (88-103): Q = 4.0
-    - 112 (104-119): Q = 5.6
-    - 127 (120-127): Q = 8.0 (max)
+    - 16 (0-19): Q = 0.7 (min)
+    - 24 (20-27): Q = 0.8
+    - 32 (28-35): Q = 1.0
+    - 40 (36-43): Q = 1.2
+    - 48 (44-51): Q = 1.4
+    - 56 (52-59): Q = 1.7
+    - 64 (60-67): Q = 2.0
+    - 72 (68-75): Q = 2.4
+    - 80 (76-83): Q = 2.8
+    - 88 (84-91): Q = 3.4
+    - 96 (92-99): Q = 4.0
+    - 104 (100-107): Q = 4.8
+    - 112 (108-115): Q = 5.6
+    - 120 (116-123): Q = 6.7
+    - 127 (124-127): Q = 8.0 (max)
 - Filter EG Amt [-|+], LFO Filter Amt [-|+]
     - -60 (4): -60 (min)
     - +60 (124): +60 (max)

diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
-# Digital Synth PRA32-U v2.0.0
+# Digital Synth PRA32-U v2.0.1
 
-- 2024-01-04 ISGK Instruments
+- 2024-01-05 ISGK Instruments
 - <https://github.com/risgk/digital-synth-pra32-u>
 
 
@@ -12,11 +12,14 @@
 - Modifiable with Arduino IDE and Arduino-Pico (by Earle F. Philhower, III)
 - An **I2S DAC** hardware (e.g. Pimoroni Pico Audio Pack and Waveshare Pico-Audio) is required
 - Prebuilt UF2 files ("bin")
-    - "Digital-Synth-PRA32-U-2.0.0-Pimoroni-Pico-Audio-Pack.uf2" is for Raspberry Pi Pico and Pimoroni Pico Audio Pack
+    - "Digital-Synth-PRA32-U-2.0.1-Pimoroni-Pico-Audio-Pack.uf2" is for Raspberry Pi Pico and Pimoroni Pico Audio Pack
 
 
 ## Change History
 
+- v2.0.1:
+    - Fix Ping Pong Delay to start from the left
+    - Fix Parameter Guide (Filter Resonance)
 - v2.0.0:
     - Add Delay Mode (Ping Pong Delay);
     - Support Breath Controller (Breath Filter Amt and Breath Amp Mod);
@@ -257,11 +260,11 @@ graph LR
 
 ![CC0](http://i.creativecommons.org/p/zero/1.0/88x31.png)
 
-**Digital Synth PRA32-U v2.0.0 by ISGK Instruments (Ryo Ishigaki)**
+**Digital Synth PRA32-U v2.0.1 by ISGK Instruments (Ryo Ishigaki)**
 
 To the extent possible under law, ISGK Instruments (Ryo Ishigaki)
 has waived all copyright and related or neighboring rights
-to Digital Synth PRA32-U v2.0.0.
+to Digital Synth PRA32-U v2.0.1.
 
 You should have received a copy of the CC0 legalcode along with this
 work.  If not, see <http://creativecommons.org/publicdomain/zero/1.0/>.
diff --git a/...RA32-U-2.0.0-Pimoroni-Pico-Audio-Pack.uf2 → ...RA32-U-2.0.1-Pimoroni-Pico-Audio-Pack.uf2 b/...RA32-U-2.0.0-Pimoroni-Pico-Audio-Pack.uf2 → ...RA32-U-2.0.1-Pimoroni-Pico-Audio-Pack.uf2
diff --git a/pra32-u-ctrl.html b/pra32-u-ctrl.html
@@ -41,7 +41,7 @@
 }
 </style>
 <script>
-const APP_NAME_VERSION = "PRA32-U CTRL v2.0.0";
+const APP_NAME_VERSION = "PRA32-U CTRL v2.0.1";
 
 const MIDI_CH        = 0;       // 0-based
 

diff --git a/pra32-u-prog-preset.json b/pra32-u-prog-preset.json
@@ -1,5 +1,5 @@
 {
-  "_version     " : "PRA32-U CTRL v2.0.0",
+  "_version     " : "PRA32-U CTRL v2.0.1",
   "_comment     " : "  CURRENT  #8   #9   #10  #11  #12  #13  #14  #15  ",
   "OSC_1_WAVE     " : [ [127], [127, 127, 127, 127, 127, 127, 127, 0  ] ],
   "OSC_1_SHAPE    " : [ [0  ], [0  , 0  , 0  , 0  , 0  , 0  , 0  , 0  ] ],