Skip to content

Commit

Permalink
Trying harder to silence codeql
Browse files Browse the repository at this point in the history
Signed-off-by: Ricardo Dias <[email protected]>
  • Loading branch information
rjd15372 committed Feb 7, 2025
1 parent 7c96c1f commit eca8307
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/valkey-benchmark.c
Original file line number Diff line number Diff line change
Expand Up @@ -1635,9 +1635,9 @@ char *generateFunctionScript(uint32_t num_functions, int with_keys) {
memset(buffer, 0, buffer_len);

int written = snprintf(buffer, buffer_len, "#!lua name=benchlib\n");
while (num_functions > 0) {
while (num_functions > 0 && (buffer_len - written) > 0) {
assert(buffer_len - written > 0);
int n = 0;
size_t n = 0;
if (with_keys) {
n = snprintf(buffer + written, buffer_len - written,
"local function foo%u(keys, args)\nreturn keys[0]\nend\n",
Expand All @@ -1647,14 +1647,16 @@ char *generateFunctionScript(uint32_t num_functions, int with_keys) {
"local function foo%u()\nreturn 0\nend\n",
num_functions);
}
assert(n > 0 && n < buffer_len - written);

if (n < 0 || n >= buffer_len - written) {
break;
}
written += n;

n = snprintf(buffer + written, buffer_len - written,
"server.register_function('foo%u', foo%u)\n",
num_functions,
num_functions);
assert(n > 0 && n < buffer_len - written);
written += n;

num_functions--;
Expand Down

0 comments on commit eca8307

Please sign in to comment.