Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback isValid() in retrieveSchema() to validateFormData() #4418

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cewald
Copy link

@cewald cewald commented Dec 16, 2024

Reasons for making this change

fixes #4357

This reverts commit ff46301

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Copy link
Member

@heath-freenome heath-freenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question and a small change to the CHANGELOG.md and you are good to go

packages/core/test/Form.test.jsx Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@heath-freenome
Copy link
Member

@cewald It looks like something in the utils tests are breaking. Can you please take a look... Also there are a few questions/concerns to address

@cewald
Copy link
Author

cewald commented Jan 13, 2025

I did not had time for checking the tests yet – but I actually "just reverted the changes". So there might be changes in the meantime that rely on the new version of code. Idk. I dont think I find time to debug those tests anytime soon, as I am not that much into the code and would need some time for research.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty enum is blocking dependency after v5.5.1
2 participants