Skip to content

Commit

Permalink
[PDPI] Remove broken & redundant test. (sonic-net#173)
Browse files Browse the repository at this point in the history

* [PDPI] Remove broken & redundant test.


---------

Co-authored-by: smolkaj <[email protected]>
Co-authored-by: kishanps <[email protected]>
  • Loading branch information
3 people authored Jun 4, 2024
1 parent bd6fe1c commit 5bf336d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.
5 changes: 0 additions & 5 deletions p4_pdpi/testing/rpc_test_runner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -355,11 +355,6 @@ static void RunReadRequestTests(pdpi::IrP4Info info) {
entities { table_entry {} }
entities { table_entry {} }
)pb"));
RunPiReadRequestTest(info, "valid",
gutil::ParseProtoOrDie<p4::v1::ReadRequest>(R"pb(
device_id: 10
entities { table_entry {} }
)pb"));

// There are no invalid IR read requests, so no RunIrReadRequestTest is
// needed.
Expand Down
16 changes: 0 additions & 16 deletions p4_pdpi/testing/testdata/rpc.expected
Original file line number Diff line number Diff line change
Expand Up @@ -49,22 +49,6 @@ entities {
--- PI is invalid/unsupported:
UNIMPLEMENTED: Only wildcard reads of all table entries are supported. Only 1 entity is supported. Found 2 entities in read request.

=========================================================================
ReadRequest test: valid
=========================================================================

--- PI (Input):
device_id: 10
entities {
table_entry {
}
}

TEST FAILED (DO NOT SUBMIT)
TEST NAME: ReadRequest test: valid
FAILURE REASON: Expected PI to be invalid (valid PI should instead be tested using RunGenericPdTest.


=========================================================================
ReadRequest test: no meter, no counter
=========================================================================
Expand Down

0 comments on commit 5bf336d

Please sign in to comment.