Skip to content

Commit

Permalink
🎨 Small improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
rlemaitre-ledger committed Nov 28, 2023
1 parent bf29942 commit 335ff33
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 9 deletions.
1 change: 1 addition & 0 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ build:
--variable=highlightjs:true \
--variable=highlightjs-theme:monokai \
--variable=navigationMode:linear \
--variable="slideNumber:'c'" \
--variable="keyboard:{13: 'next', 33: 'prev', 34: 'next'}" \
--slide-level=2 \
--output={{target}}/{{output}} \
Expand Down
43 changes: 34 additions & 9 deletions slides.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ date: November 28th, 2023
:::
::::::

# Rationale
# Story time

## {data-auto-animate=""}
##

Suppose you find this code in your codebase

Expand Down Expand Up @@ -58,7 +58,6 @@ val iban = IBAN(
"06"
)
```
[👍]{style="font-size: 400%;"}

## {data-auto-animate=""}

Expand All @@ -74,11 +73,41 @@ val shuffled = IBAN(
"01005"
)
```
[🤔]{style="font-size: 400%;"}
[🧑‍💻]{style="font-size: 400%;"}

## {data-auto-animate=""}

Until you find something like this

```scala {data-id="code" data-line-numbers=""}
val shuffled = IBAN(
"0500013M026",
"FR",
"06",
"14",
"20041",
"01005"
)
```

## {data-auto-animate=""}

So, you try this

```scala {data-id="code" data-line-numbers=""}
val wtf = IBAN(
"🇫🇷",
"",
"🏦",
"🌳",
"🧾",
"🤡"
)
```

## {data-auto-animate=""}

Then, you see this
So, you try this

```scala {data-id="code" data-line-numbers=""}
val wtf = IBAN(
Expand All @@ -90,7 +119,6 @@ val wtf = IBAN(
"🤡"
)
```
[🤯]{style="font-size: 400%;"}

# How can we do better?

Expand Down Expand Up @@ -161,7 +189,6 @@ val iban = IBAN(
NationalCheckDigit("06")
)
```
[👍]{style="font-size: 400%;"}

## {data-auto-animate=""}

Expand All @@ -177,7 +204,6 @@ val shuffled = IBAN(
BranchCode("01005")
)
```
[👍]{style="font-size: 400%;"}

## {data-auto-animate=""}

Expand All @@ -193,7 +219,6 @@ val wtf = IBAN(
NationalCheckDigit("🤡")
)
```
[😤]{style="font-size: 400%;"}

## Let's add validation

Expand Down

0 comments on commit 335ff33

Please sign in to comment.