Implemented "System" option for theme. #999
Merged
+20
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmcrackan
reviewed
Oct 14, 2024
| { | ||
| nameof(ThemeVariant.Dark) => ThemeVariant.Dark, | ||
| nameof(ThemeVariant.Light) => ThemeVariant.Light, | ||
| // "System" |
There was a problem hiding this comment.
Thank you for adding this comment. It's obvious now, but unlabeled else and default cases can be so tiresome to figure out while your brain is 4 abstractions deep during debugging.
|
Thanks! I'll include it in the same release as #997 when that's finalized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find the option to change this in Winforms, however the default for new installs is now "System" so it will still benefit from the change.
Issue #998