Make sat reproducible #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelnaranjo
force-pushed
the
mnaranjo/make-sat-reproducible
branch
from
16fba88 to
73c4e4a
Compare
|
This run shows the test failing before we sort the inputs to the SAT resolver |
kellyma2
reviewed
Jan 14, 2025
kellyma2
reviewed
Jan 14, 2025
pkg/sat/sat.go
Outdated
| @@ -146,8 +162,13 @@ func (r *Resolver) LoadInvolvedPackages(packages []*api.Package, ignoreRegex []s | |||
|
|
|||
| if !r.nobest { | |||
| packages = nil | |||
| for _, v := range r.bestPackages { | |||
| packages = append(packages, v) | |||
| bestPackagesKeys := make([]string, 0, len(r.bestPackages)) | |||
There was a problem hiding this comment.
maybe use maps.Keys for this?
There was a problem hiding this comment.
I'm not a go expert, so TIL about it, I'll make the change, it looks way cleaner
Reduce some tech debt by using cmp.Or instead of multi level ifs.
Will make use of slices.Sort and slices.SortFunc so we can sort dictionary keys before we send them to the sat resolver
Check if by making the input to sat stable the output is also stable
manuelnaranjo
force-pushed
the
mnaranjo/make-sat-reproducible
branch
from
ed0a589 to
0b90edb
Compare
Make sure the sat solver output is deterministic and reproducible by making the input order stable
manuelnaranjo
force-pushed
the
mnaranjo/make-sat-reproducible
branch
from
0b90edb to
e9f6570
Compare
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make the output of the sat resolver deterministic