Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bumps all golang deps #87

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

manuelnaranjo
Copy link
Collaborator

bumping all golang deps to close a few dependabots issues

bumping all golang deps to close a few dependabots issues
@manuelnaranjo manuelnaranjo self-assigned this Jan 13, 2025
@@ -1,30 +1,31 @@
module github.com/rmohr/bazeldnf

go 1.19
go 1.22.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use 1.21.x? It's still a supported release.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, nix that. 1.22 is probably fine as the release of 1.24.x is imminent. However, do we want to use 1.22.10 here as there's a bunch of security fixes and such?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use 1.21.x? It's still a supported release.

When we run go through bazel we get:

$ bazel run @rules_go//go  -- env 2>/dev/null | grep GOVERSION
GOVERSION='go1.22.7'

Don't forget that go is managed by rules_go and not provided by the host

Actually, nix that. 1.22 is probably fine as the release of 1.24.x is imminent. However, do we want to use 1.22.10 here as there's a bunch of security fixes and such?

Sure but you would still pin to 1.22.0 in the go.mod, that's what we get when we do a go mod tidy with a newer go, the minor does not matter at all.

We manage go.mod with the same go version as it points to the right go.mod

bazel run @rules_go//go  -- env 2>/dev/null | grep GOMOD=
GOMOD='<workspace>/go.mod'

I'll merge this change then

@manuelnaranjo manuelnaranjo merged commit 4bbf4e5 into main Jan 14, 2025
13 checks passed
@manuelnaranjo manuelnaranjo deleted the mnaranjo/bump-go-dependencies branch January 14, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants