General improvements #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the logrus level can be changed through the environment variable LOG_LEVEL
Now the cache dir is global and can be configured properly, by default it goes into XDG_CACHE_HOME/bazeldnf, this is useful when dealing with multiple bazel repositories using bazeldnf.
Now the cache will expand paths to honor ~
When getting an arch make sure to expand to noarch as well, because some RPMs may have dependencies that have no architecture, this seems to be how RPM work
kellyma2
reviewed
Jan 15, 2025
| cacheDir = append(cacheDir, cacheHelperValues.cacheDir); | ||
| } else if (len(cacheDir) > 1) { | ||
| func expand(path string) (string, error) { | ||
| if len(path) == 0 || path[0] != '~' { |
There was a problem hiding this comment.
I believe the recommended approach here is to:
(1) replace ~ with $HOME
(2) os.Expand(path)
This will cover more than just tilde expansion because it'll substitute all of the local environment variables.
There was a problem hiding this comment.
Good idea, I'll do that
kellyma2
reviewed
Jan 15, 2025
Sure, I was going to wait for you to merge first anyway |
|
I'll close this PR and move it to my company fork by now, as I can't push force into the branch and fix the commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles a bunch of non related changes I've been working on while getting ready for bzlmod support with a lock file.
It includes: