Skip to content

Commit

Permalink
rtracklayer is available on Bioc, clarify NEWS and deprecation messages.
Browse files Browse the repository at this point in the history
  • Loading branch information
kriemo committed Dec 27, 2024
1 parent 8360cc8 commit 46aa92a
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 7 deletions.
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# valr (development version)

* `read_bigwig()` and `read_gtf()` were deprecated as rtracklayer is no longer avilable on CRAN.
* `read_bigwig()` and `read_gtf()` were deprecated. The rtracklayer package used
for this functionality is no longer a dependency of valr due to errors from
CRAN AddressSantizer checks of the UCSC c-library code vendored in rtracklayer.

* valr now depends on R >= 4.0.0.

Expand Down
18 changes: 12 additions & 6 deletions R/read_bed.r
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,14 @@ read_bigwig <- function(path, set_strand = "+") {
what = "read_bigwig()",
details = c(
x = paste0(
"read_bigwig() was removed because rtracklayer is",
"no longer available on CRAN"
"read_bigwig() was removed because rtracklayer does not pass ",
"CRAN AddressSantizer checks of the UCSC C-library code vendored ",
"in rtracklayer."
),
i = paste0(
"use `bigWigToBedGraph` to convert bw to bedGraph,",
"and then `read_bedgraph()`."
" and then `read_bedgraph()`. Alternatively use ",
"`rtracklayer::import()` then `gr_to_bed()`."
)
)
)
Expand Down Expand Up @@ -238,10 +240,14 @@ read_gtf <- function(path, zero_based = TRUE) {
what = "read_gtf()",
details = c(
x = paste0(
"read_gtf() was removed because rtracklayer is",
"no longer available on CRAN"
"read_gtf() was removed because rtracklayer does not pass ",
"CRAN AddressSantizer checks of the UCSC C-library code vendored ",
"in rtracklayer."
),
i = "convert GTF to BED, and then `read_bed()`."
i = paste0(
"convert GTF to BED, and then `read_bed()`, ",
"or use `rtracklayer::import()` then `gr_to_bed()`."
)
)
)
}

0 comments on commit 46aa92a

Please sign in to comment.