Skip to content

Commit

Permalink
target/hexagon: Rename macros.inc -> macros.h.inc
Browse files Browse the repository at this point in the history
Since commits 139c183 ("meson: rename included C source files
to .c.inc") and 0979ed0 ("meson: rename .inc.h files to .h.inc"),
EMU standard procedure for included header files is to use *.h.inc.

Besides, since commit 6a0057a ("docs/devel: make a statement
about includes") this is documented in the Coding Style:

  If you do use template header files they should be named with
  the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are
  being included for expansion.

Therefore rename "macros.inc" as "macros.h.inc".

Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Brian Cain <[email protected]>
Reviewed-by: Anton Johansson <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
  • Loading branch information
philmd authored and Michael Tokarev committed Sep 20, 2024
1 parent 0addb05 commit b8daa5f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion target/hexagon/gen_idef_parser_funcs.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def main():
tagimms = hex_common.get_tagimms()

with open(sys.argv[-1], "w") as f:
f.write('#include "macros.inc"\n\n')
f.write('#include "macros.h.inc"\n\n')

for tag in hex_common.tags:
## Skip the priv instructions
Expand Down
4 changes: 2 additions & 2 deletions target/hexagon/idef-parser/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ we obtain the pseudo code
with macros such as ``fJUMPR`` intact.

The second step is to expand macros into a form suitable for our parser.
These macros are defined in ``idef-parser/macros.inc`` and the step is
These macros are defined in ``idef-parser/macros.h.inc`` and the step is
carried out by the ``prepare`` script which runs the C preprocessor on
``idef_parser_input.h.inc`` to produce
``idef_parser_input.preprocessed.h.inc``.
Expand Down Expand Up @@ -266,7 +266,7 @@ in plain C is defined as
#define fABS(A) (((A) < 0) ? (-(A)) : (A))

and returns the absolute value of the argument ``A``. This macro is not included
in ``idef-parser/macros.inc`` and as such is not expanded and kept as a "call"
in ``idef-parser/macros.h.inc`` and as such is not expanded and kept as a "call"
``fABS(...)``. Reason being, that ``fABS`` is easier to match and map to
``tcg_gen_abs_<width>``, compared to the full ternary expression above. Loads of
macros in ``macros.h`` are kept unexpanded to aid in parsing, as seen in the
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion target/hexagon/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ if idef_parser_enabled and 'hexagon-linux-user' in target_dirs
'idef_parser_input.preprocessed.h.inc',
output: 'idef_parser_input.preprocessed.h.inc',
input: idef_parser_input_generated,
depend_files: [idef_parser_dir / 'macros.inc'],
depend_files: [idef_parser_dir / 'macros.h.inc'],
command: [idef_parser_dir / 'prepare', '@INPUT@', '-I' + idef_parser_dir, '-o', '@OUTPUT@'],
)

Expand Down

0 comments on commit b8daa5f

Please sign in to comment.