Skip to content

Commit

Permalink
qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED
Browse files Browse the repository at this point in the history
slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED.
This macro never existed.  The reference got added in commit
e3d4d25 "guest agent: add guest agent RPCs/commands" along with
QERR_QGA_LOGGING_FAILED, so maybe that one was meant.  However,
QERR_QGA_LOGGING_FAILED was never actually used, and was removed in
commit d73f0be "qerror.h: Remove unused error classes".

Drop the dangling reference.

Signed-off-by: Markus Armbruster <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
Reviewed-by: Konstantin Kostiuk <[email protected]>
  • Loading branch information
Markus Armbruster committed Feb 23, 2023
1 parent 36ebc7d commit c402335
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions qga/commands.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,8 @@
#define GUEST_FILE_READ_COUNT_MAX (48 * MiB)

/* Note: in some situations, like with the fsfreeze, logging may be
* temporarilly disabled. if it is necessary that a command be able
* to log for accounting purposes, check ga_logging_enabled() beforehand,
* and use the QERR_QGA_LOGGING_DISABLED to generate an error
* temporarily disabled. if it is necessary that a command be able
* to log for accounting purposes, check ga_logging_enabled() beforehand.
*/
void slog(const gchar *fmt, ...)
{
Expand Down

0 comments on commit c402335

Please sign in to comment.