Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 115 custom fields using the
mex:
namespace.These custom fields are derived from the 3.4.0 version of the MEx metadata model.
There is some validation implemented using little effort but this should not be required as incoming data will already have been validated using the model.
The
mex:identifier
field is the onlyrequired
custom field.The resource types vocabulary has been replaced with 11 MEx entity types. Please verify that these are the correct entity types.
The custom nested field class
MultiLanguageTextCF
is modelled on the MEx text field.Templates
Three templates has been amended,
records/detail.html
which includesrecords/details/mex_details.html
andrecords/macros/mex_detail.html
only in order to list custom fields the same way Datacite fields are listed by default on the landing page.The templates have also been changed to not expect a
props
property defined in theRDM_CUSTOM_FIELDS_UI
config variable. In other words, if these amended templates were not used, Jinja would throw an error expecting each field in that config variable to have aprops
property set.Unresolved
This PR does not have unit tests. They are coming soon in a PR for importing data.
There are still decisions to be made on the searchability of these custom fields, if and then how they are searched on or faceted.