Broadcast zero point vector when converting batched matmul to non-batched #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
force-pushed
the
broadcast-matmul-zero-point
branch
2 times, most recently
from
f90c865 to
ad04fbd
Compare
When a batched matmul `[A, M, K] x [K, N]` is converted to a non-batched matmul with LHS shape `[A * M, K]` the zero point needs to be broadcast to match the new row count. This fixes an error when running the Segment Anything demo with a quantized image encoder.
robertknight
force-pushed
the
broadcast-matmul-zero-point
branch
from
ad04fbd to
81e2328
Compare
robertknight
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a batched matmul
[A, M, K] x [K, N]is converted to a non-batched matmul with LHS shape[A * M, K]the zero point needs to be broadcast to match the new row count.This fixes an error when running the Segment Anything demo with a quantized image encoder.