Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: Supporting creating executable memory #746

Merged
merged 5 commits into from
Oct 31, 2023
Merged

os: Supporting creating executable memory #746

merged 5 commits into from
Oct 31, 2023

Conversation

robinlinden
Copy link
Owner

This is needed for some ongoing wasm jit-compilation experiments.

Copy link
Contributor

@GrayHatter GrayHatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major concerns. I might have said it looks way to easy to lose track of this memory, but you already said basically the same thing to me 😅

@robinlinden
Copy link
Owner Author

No major concerns. I might have said it looks way to easy to lose track of this memory, but you already said basically the same thing to me 😅

Thanks again for having a look! Will split the lib up like we talked about, so we have some separation of concerns in os.h and don't stick exec-memory-management together with getting the os' font dirs.

@robinlinden robinlinden force-pushed the os-exec-mem branch 2 times, most recently from a90ed24 to 0e2fd13 Compare October 29, 2023 18:50
@robinlinden robinlinden marked this pull request as ready for review October 29, 2023 20:57
@robinlinden robinlinden merged commit 7a670ea into master Oct 31, 2023
21 of 22 checks passed
@robinlinden robinlinden deleted the os-exec-mem branch October 31, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants