Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unnecessary dependencies #784

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Clean up unnecessary dependencies #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cd89f1
render: Clean up includes and unnecessary dependencies
robinlinden Dec 4, 2023
e312894
util/base_parser: Remove unnecessary util/string-dependency
robinlinden Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions render/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ cc_library(
"//css",
"//gfx",
"//layout",
"//util:from_chars",
"//util:string",
"@spdlog",
],
)
Expand Down
9 changes: 0 additions & 9 deletions render/render.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,11 @@

#include "css/property_id.h"
#include "gfx/color.h"
#include "util/from_chars.h"
#include "util/string.h"

#include <spdlog/spdlog.h>

#include <algorithm>
#include <charconv>
#include <cstdint>
#include <cstring>
#include <sstream>
#include <string_view>
#include <variant>

using namespace std::literals;

namespace render {
namespace {
Expand Down
2 changes: 1 addition & 1 deletion render/render.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#define RENDER_RENDER_H_

#include "gfx/icanvas.h"
#include "layout/layout.h"
#include "layout/layout_box.h"

namespace render {

Expand Down
2 changes: 1 addition & 1 deletion render/render_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "gfx/canvas_command_saver.h"
#include "gfx/color.h"
#include "gfx/icanvas.h"
#include "layout/layout.h"
#include "layout/layout_box.h"
#include "style/styled_node.h"

#include <string_view>
Expand Down
8 changes: 0 additions & 8 deletions util/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("//bzl:copts.bzl", "HASTUR_COPTS")

dependencies = {
"base_parser": [":string"],
}

[cc_library(
name = hdr[:-2],
hdrs = [hdr],
copts = HASTUR_COPTS,
visibility = ["//visibility:public"],
deps = dependencies.get(
hdr[:-2],
[],
),
) for hdr in glob(["*.h"])]

[cc_test(
Expand Down
2 changes: 0 additions & 2 deletions util/base_parser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
#ifndef UTIL_BASE_PARSER_H_
#define UTIL_BASE_PARSER_H_

#include "util/string.h"

#include <cstddef>
#include <optional>
#include <string_view>
Expand Down