Extend Roact JSX documentation #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I personally struggled with finding out this information, and think it would be quite useful to include it within the documentation. It might need some rewording, however this is mainly to illustrate what I'm trying to add into the documentation and what use-cases it might have. The example seems simple yet is not being explained, a developer that isn't aware of ``IntrinsicElements`` or it's purpose might be confused here - should I extend the section to quickly explain why ``IntrinsicElements`` is being extended and how it relates to ``JSX`` (Or link to an external resource that does this)? For JSX naming conventions, perhaps instead of explaining it link to https://roblox-ts.com/docs/guides/roact-jsx/#tag-names? More feedback needed on this. 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally struggled with finding out this information, and think it would be quite useful to include it within the documentation.
It might need some rewording, however this is mainly to illustrate what I'm trying to add into the documentation and what use-cases it might have.
The example seems simple yet is not being explained, a developer that isn't aware of
IntrinsicElementsor it's purpose might be confused here - should I extend the section to quickly explain whyIntrinsicElementsis being extended and how it relates toJSX(Or link to an external resource that does this)?For JSX naming conventions, perhaps instead of explaining it link to https://roblox-ts.com/docs/guides/roact-jsx/#tag-names?
More feedback needed on this. 😊