Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buffer library #1120

Merged
merged 3 commits into from
Dec 24, 2023
Merged

Add buffer library #1120

merged 3 commits into from
Dec 24, 2023

Conversation

rimuy
Copy link
Contributor

@rimuy rimuy commented Nov 30, 2023

No description provided.

@rimuy rimuy marked this pull request as draft November 30, 2023 20:43
@rimuy rimuy changed the title Add typings for the new buffer library Add buffer library Nov 30, 2023
@Vorlias
Copy link
Contributor

Vorlias commented Dec 5, 2023

CheckableTypes should include buffer: buffer - as typeof(buffer) == "buffer".

@rimuy
Copy link
Contributor Author

rimuy commented Dec 5, 2023

That would actually be CheckablePrimitives, thanks for the heads up.

@rimuy rimuy marked this pull request as ready for review December 23, 2023 21:45
@osyrisrblx osyrisrblx merged commit 40674ef into roblox-ts:master Dec 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rimuy @Vorlias @osyrisrblx