Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom definitions for EditableMesh #1193

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

LouieK22
Copy link
Contributor

@LouieK22 LouieK22 commented Mar 1, 2024

image

closes #1191

Pending discussion item: Do we want to replace number with VertexId or FaceId (or equivalent) where applicable? (Original discussion).

@jisham318
Copy link
Contributor

LGTM, love it! beat me to the punch

@osyrisrblx osyrisrblx merged commit 8b1a849 into roblox-ts:master Mar 11, 2024
1 of 2 checks passed
@LouieK22 LouieK22 deleted the editable-mesh branch March 15, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditableMesh autogenerated types have a lot of unknown
3 participants