Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define return types for certain MarketPlaceService methods #1290

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Define return types for certain MarketPlaceService methods #1290

merged 5 commits into from
Aug 22, 2024

Conversation

NormalDuck
Copy link
Contributor

I named it SubscriptionProductInfoAsync because there is already SubscriptionProductInfo

NormalDuck and others added 4 commits August 22, 2024 11:06
@NormalDuck
Add GetSubscriptionProductInfoAsync
9e8e2a5 
`GetUserSubscriptionDetailsAsync`
`GetUserSubscriptionPaymentHistoryAsync`
`GetUserSubscriptionStatusAsync` functions with defined return values
@NormalDuck
style: fix the styling of the code
09239b7
@NormalDuck
style: fix eslint errors
6708fcc
@NormalDuck
style: narrow down a ExpirationDetails and rename SubscriptionProduct…
5b50477 
…InfoAsync to SubscriptionInfo
@NormalDuck
Copy link
Contributor Author

SubscriptionProductInfoAsync changed into SubscriptionInfo

@osyrisrblx osyrisrblx merged commit 48e3319 into roblox-ts:master Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NormalDuck @osyrisrblx