-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed types generator #1325
base: master
Are you sure you want to change the base?
Fixed types generator #1325
Conversation
Does this fix support the new(ish) method for creating blank editable images? https://create.roblox.com/docs/reference/engine/classes/AssetService#CreateEditableImage |
It should. |
You should remove the PRs you listed from this PR and keep the scope to fixing the types generator, if that was your original intention. It doesn't make sense to bubble up several other failing ones into your own and then ask maintainers to close them. Additionally, my PR needs a fix to actually include the x/y/z properties. |
True, I did ask about it though, they said it was fine, I can remove them. The only one that I need to move here was the |
I'm with Jack, the PR should be limited to fixing the build failures. The other PRs can be re-checked and merged afterwards. |
Fixed types generator failing:
RENAME_CLASSES
Object
in the args generatorEditableMesh
/EditableImage
typesContentId
typeRBXObject
RBXObject
math.map
I also added current open prs where checks failed due to the generator. This would also close these pull requests:
vector
type: Luau vector types #1323Player.GetJoinData()
: fix: Player.GetJoinData() #1324BoundActionInfo
type: Fix BoundActionInfo type. #1319