Allow downloads for non object-detection models #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeldarby
approved these changes
Jan 31, 2024
bigbitbus
reviewed
Jan 31, 2024
| r = requests.get(pt_api_url, params={"api_key": self.__api_key}) | ||
|
|
||
| r.raise_for_status() | ||
|
|
There was a problem hiding this comment.
Why is the bar_progress removed?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves download logic into the base class to allow download of any model. Whether the model can be downloaded is controlled server-side, so in the future, model downloads can be added server-side without the need for client changes.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested in staging.
Any specific deployment considerations
Will need to release a new version of the sdk.
Docs