Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI pipeline #20

Merged
merged 23 commits into from
Mar 3, 2024
Merged

CI pipeline #20

merged 23 commits into from
Mar 3, 2024

Conversation

dfbakin
Copy link
Member

@dfbakin dfbakin commented Feb 18, 2024

Test

Summary

This PR proposes CI pipeline that formats, lints, builds and tests ROS2 packages under a docker container, specified by docker-compose.yaml
It is planned to expand this PR with docker auto-deploy feature and then scale it to all repos after code reviews and codestyle discussions

Main features

  • linting Python and C++ code
  • self-hosted runners are used

Other information

TODOs:

  • add pre-commit to docker image and fix the cache in CI
  • mark CI check as "Required" for a PR to be closed

@dfbakin dfbakin added the invalid This doesn't seem right label Feb 18, 2024
@dfbakin dfbakin changed the title DRAFT -- will be closed DRAFT -- not for merge Feb 20, 2024
.github/workflows/build_check.yml Outdated Show resolved Hide resolved
.github/workflows/build_check.yml Outdated Show resolved Hide resolved
.github/workflows/build_check.yml Outdated Show resolved Hide resolved
.github/workflows/build_check.yml Outdated Show resolved Hide resolved
.github/workflows/build_check.yml Outdated Show resolved Hide resolved
.github/workflows/build_check.yml Outdated Show resolved Hide resolved
.github/workflows/build_check.yml Outdated Show resolved Hide resolved
.github/workflows/codestyle_check.yml Outdated Show resolved Hide resolved
@dfbakin dfbakin self-assigned this Feb 20, 2024
@dfbakin dfbakin added enhancement New feature or request and removed invalid This doesn't seem right labels Feb 21, 2024
.clang-tidy Outdated Show resolved Hide resolved
.clang-tidy Show resolved Hide resolved
.clang-tidy Show resolved Hide resolved
.clang-tidy Show resolved Hide resolved
.clang-tidy Outdated Show resolved Hide resolved
.clang-tidy Outdated Show resolved Hide resolved
@dfbakin dfbakin changed the title DRAFT -- not for merge CI pipeline Feb 21, 2024
.clang-tidy Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
@dasimagin
Copy link
Member

dasimagin commented Feb 24, 2024

bugprone-argument-comment
bugprone-assert-side-effect
bugprone-assignment-in-if-condition
bugprone-branch-clone
bugprone-casting-through-void
bugprone-chained-comparison
bugprone-compare-pointer-to-member-virtual-function
bugprone-copy-constructor-init
bugprone-dangling-handle
bugprone-fold-init-type
bugprone-forward-declaration-namespace
bugprone-inc-dec-in-conditions
bugprone-move-forwarding-reference
bugprone-parent-virtual-call
bugprone-redundant-branch-condition
bugprone-shared-ptr-array-mismatch
bugprone-sizeof-expression
bugprone-standalone-empty
bugprone-string-constructor
bugprone-string-literal-with-embedded-nul
bugprone-stringview-nullptr
bugprone-suspicious-enum-usage
bugprone-suspicious-include
bugprone-suspicious-missing-comma
bugprone-suspicious-semicolon
bugprone-suspicious-string-compare
bugprone-switch-missing-default-case
bugprone-throw-keyword-missing
bugprone-unhandled-exception-at-new
bugprone-unhandled-self-assignment
bugprone-unique-ptr-array-mismatch
bugprone-unused-local-non-trivial-variable
bugprone-unused-raii
bugprone-unused-return-value
bugprone-use-after-move

google-build-explicit-make-pair
google-build-namespaces
google-build-using-namespace
google-default-arguments
google-readability-avoid-underscore-in-googletest-name
google-readability-casting
google-runtime-int

llvm-header-guard
llvm-include-order
llvm-namespace-comment

misc-const-correctness
misc-definitions-in-headers
misc-header-include-cycle
misc-include-cleaner
misc-redundant-expression
misc-static-assert
misc-unconventional-assign-operator
misc-uniqueptr-reset-release
misc-unused-alias-decls
misc-unused-parameters
misc-unused-using-decls
misc-use-anonymous-namespace

modernize-avoid-bind
modernize-concat-nested-namespaces
modernize-deprecated-headers
modernize-deprecated-ios-base-aliases
modernize-macro-to-enum
modernize-make-shared
modernize-make-unique
modernize-pass-by-value
modernize-redundant-void-arg
modernize-replace-disallow-copy-and-assign-macro
modernize-return-braced-init-list
modernize-type-traits
modernize-unary-static-assert
modernize-use-auto
modernize-use-bool-literals
modernize-use-default-member-init
modernize-use-emplace
modernize-use-equals-default
modernize-use-equals-delete
modernize-use-nullptr
modernize-use-override
modernize-use-starts-ends-with
modernize-use-std-numbers
modernize-use-std-print
modernize-use-transparent-functors
modernize-use-using

performance-faster-string-find
performance-for-range-copy
performance-implicit-conversion-in-loop
performance-inefficient-algorithm
performance-inefficient-string-concatenation
performance-inefficient-vector-operation
performance-move-const-arg
performance-move-constructor-init
performance-no-automatic-move
performance-no-int-to-ptr
performance-noexcept-destructor
performance-noexcept-move-constructor
performance-noexcept-swap
performance-trivially-destructible
performance-type-promotion-in-math-fn
performance-unnecessary-copy-initialization
performance-unnecessary-value-param

readability-avoid-const-params-in-decls
readability-avoid-nested-conditional-operator
readability-avoid-return-with-void-value
readability-avoid-unconditional-preprocessor-if
readability-braces-around-statements
readability-const-return-type
readability-container-size-empty
readability-convert-member-functions-to-static
readability-duplicate-include
readability-else-after-return
readability-inconsistent-declaration-parameter-name
readability-identifier-naming
readability-isolate-declaration
readability-make-member-function-const
readability-named-parameter
readability-non-const-parameter
readability-operators-representation (Traditional)
readability-qualified-auto
readability-redundant-*
readability-reference-to-constructed-temporary
readability-simplify-boolean-expr
readability-simplify-subscript-expr
readability-use-std-min-max

.clang-tidy Outdated Show resolved Hide resolved
.clang-tidy Outdated Show resolved Hide resolved
@dasimagin
Copy link
Member

Отписался от обновлений пиара, чтобы не было в списке дел.

@dfbakin dfbakin changed the title CI pipeline CI pipeline [![Test](https://github.com/robotics-laboratory/handy/actions/workflows/test.yml/badge.svg?branch=ci-pipeline)](https://github.com/robotics-laboratory/handy/actions/workflows/test.yml) Feb 28, 2024
@dfbakin dfbakin changed the title CI pipeline [![Test](https://github.com/robotics-laboratory/handy/actions/workflows/test.yml/badge.svg?branch=ci-pipeline)](https://github.com/robotics-laboratory/handy/actions/workflows/test.yml) CI pipeline Feb 28, 2024
@dfbakin dfbakin added the CI CI pipeline label Feb 28, 2024
@dfbakin dfbakin removed the request for review from AndBondStyle March 3, 2024 15:52
@dfbakin dfbakin merged commit e57dcac into master Mar 3, 2024
1 of 3 checks passed
@dfbakin dfbakin deleted the ci-pipeline branch March 3, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI pipeline enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants