Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarp-devices-ros2 conda-ci to support Jazzy #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

traversaro
Copy link
Member

Since RoboStack/ros-jazzy#5 and several follow up PRs, robostack now provides ROS Jazzy packages, so we can use them in CI. I also removed iron from the CI, as it is now EOL: https://docs.ros.org/en/iron/Releases/End-of-Life.html .

@traversaro
Copy link
Member Author

The CI fails with:

In file included from /home/runner/work/yarp-devices-ros2/yarp-devices-ros2/src/devices/frameTransformSet_nwc_ros2/frameTransformSet_nwc_ros2.cpp:6:
/home/runner/work/yarp-devices-ros2/yarp-devices-ros2/src/devices/frameTransformSet_nwc_ros2/frameTransformSet_nwc_ros2.h:72:10: error: conflicting return type specified for 'virtual bool FrameTransformSet_nwc_ros2::setTransforms(const std::vector<yarp::math::FrameTransform>&)'
   72 |     bool setTransforms(const std::vector<yarp::math::FrameTransform>& transforms) override;
      |          ^~~~~~~~~~~~~
In file included from /home/runner/work/yarp-devices-ros2/yarp-devices-ros2/src/devices/frameTransformSet_nwc_ros2/frameTransformSet_nwc_ros2.h:11:
/home/runner/miniconda3/envs/test/include/yarp/dev/IFrameTransformStorage.h:39:36: note: overridden function is 'virtual yarp::dev::ReturnValue yarp::dev::IFrameTransformStorageSet::setTransforms(const std::vector<yarp::math::FrameTransform>&)'
   39 |     virtual yarp::dev::ReturnValue setTransforms(const std::vector<yarp::math::FrameTransform>& transforms) = 0;
      |                                    ^~~~~~~~~~~~~
/home/runner/work/yarp-devices-ros2/yarp-devices-ros2/src/devices/frameTransformSet_nwc_ros2/frameTransformSet_nwc_ros2.h:73:10: error: conflicting return type specified for 'virtual bool FrameTransformSet_nwc_ros2::setTransform(const yarp::math::FrameTransform&)'
   73 |     bool setTransform(const yarp::math::FrameTransform& transform) override;
      |          ^~~~~~~~~~~~

but this is due to some braking changes in robotology/yarp#3169, that also affect the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants