Add cap to numpy and shapely version support, fix tests, upgrade precommit #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- checkout v2 -> v4 - setup-python v2 -> v5 - upload-artifact v2 -> v4 - download-artifact v2 -> v4 - codecov-action v1 -> v4
Since python no longer supports 2.7-3.7, we drop testing on these versions too. GHA no longer supports running on some of these versions.
updates: - [github.com/PyCQA/isort: 5.10.1 → 5.13.2](PyCQA/isort@5.10.1...5.13.2) - [github.com/psf/black: 21.12b0 → 24.8.0](psf/black@21.12b0...24.8.0) - [github.com/asottile/blacken-docs: v1.12.1 → 1.18.0](adamchainz/blacken-docs@v1.12.1...1.18.0) - [github.com/kynan/nbstripout: 0.5.0 → 0.7.1](kynan/nbstripout@0.5.0...0.7.1) - [github.com/nbQA-dev/nbQA: 1.3.1 → 1.8.7](nbQA-dev/nbQA@1.3.1...1.8.7) - [github.com/pre-commit/pygrep-hooks: v1.9.0 → v1.10.0](pre-commit/pygrep-hooks@v1.9.0...v1.10.0) - [github.com/pre-commit/pre-commit-hooks: v4.1.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.1.0...v4.6.0) - [github.com/PyCQA/flake8: 4.0.1 → 7.1.1](PyCQA/flake8@4.0.1...7.1.1)
In numpy 1.24, dtype=object has to be specified when creating a ragged array. In fissa, we were reliant on that being automatically detected.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
===========================================
- Coverage 94.08% 83.47% -10.62%
===========================================
Files 8 8
Lines 1217 1198 -19
Branches 313 304 -9
===========================================
- Hits 1145 1000 -145
- Misses 36 162 +126
Partials 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy>=1.13.0,<1.24andshapely>=1.5.17,<2.0as we do not currently support newer versions of these dependencies. Numpy 1.24 stopped automatically detecting ragged arrays, which now need to be specified withdtype=object. Shapely 2.0 has some backward-incompatible API changes.Closes #285. Closes #290.