Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create profile for secure-time-sync #274

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

npwc
Copy link
Contributor

@npwc npwc commented Jan 16, 2024

@roddhjav
Copy link
Owner

roddhjav commented Jan 16, 2024

Thanks for your PR. Please have a look at the profile guideline: https://apparmor.pujol.io/development/guidelines to ensure your profile respect the guideline of this project.

@{exec_path} = /usr/{,local/}bin/secure-time-sync
profile secure-time-sync @{exec_path} flags=(attach_disconnected) {
include <abstractions/base>
include <abstractions/bash>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed for bash script, remove

Comment on lines 24 to 29
owner /etc/host.conf r,
owner /etc/hosts r,
owner /etc/nsswitch.conf r,
owner /etc/passwd r,
owner /etc/resolv.conf r,
owner /etc/gai.conf r,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use nameservice-strict

Comment on lines 21 to 22
owner /etc/ca-certificates/** r,
owner /etc/ssl/** r,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ssl_certs or ssl_keys

@roddhjav roddhjav force-pushed the main branch 2 times, most recently from 7e0f337 to d3751d3 Compare January 24, 2024 20:52
@roddhjav roddhjav merged commit c3e92b3 into roddhjav:main Jan 24, 2024
2 checks passed
@roddhjav
Copy link
Owner

Thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants