Add spec for Converter
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moozzi
commented
Feb 1, 2024
moozzi
commented
Feb 1, 2024
moozzi
commented
Feb 1, 2024
spec/converter_spec.rb
Outdated
| context 'when there is no output' do | ||
| context 'and format is csv' do | ||
| let(:expected_csv) do | ||
| "type,status.status,status.protocol,status.port,status.reason,status.ttl,status.ip,status.timestamp,banner.protocol,banner.port,banner.ip,banner.timestamp,banner.app_protocol,banner.payload\nstatus,open,tcp,80,\"syn,ack\",54,93.184.216.34,2021-08-26 08:50:21 +0200\n" |
There was a problem hiding this comment.
Is there a way to make it multi-line but without adding some unnecessary \n's?
There was a problem hiding this comment.
Do you mean the last newline? You can do either:
<<~CSV.chomp
foo,bar,baz
...
CSVor
[
"foo,bar,baz",
"..."
].join("\n")There was a problem hiding this comment.
Not the last one. I don't want this expected_csv to be too long but saving it as <<CSV.chomp ... fails when I want to compare it with result of .convert
postmodern
requested changes
Feb 8, 2024
spec/fixtures/converter/masscan.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| [ | |||
| { "ip": "93.184.216.34", "timestamp": "1629960621", "ports": [ {"port": 80, "proto": "tcp", "status": "open", "reason": "syn-ack", "ttl": 54} ] } | |||
There was a problem hiding this comment.
Should rebase this branch to get the new spec/fixtures/converter/input.json.
moozzi
force-pushed
the
add_converter_spec
branch
from
a22b72e to
14d5bf6
Compare
I'll add it later. |
postmodern
approved these changes
Apr 29, 2024
Make the spec variables more consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1