Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for Converters::JSON #18

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Add spec for Converters::JSON #18

merged 3 commits into from
Feb 6, 2024

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Feb 3, 2024

#1

Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on the specs.

spec/converters/json_spec.rb Outdated Show resolved Hide resolved
spec/converters/json_spec.rb Outdated Show resolved Hide resolved
spec/converters/json_spec.rb Outdated Show resolved Hide resolved
spec/fixtures/converter/masscan.json Outdated Show resolved Hide resolved
spec/converters/json_spec.rb Show resolved Hide resolved
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a left behind file.

spec/fixtures/converter/masscan.json Outdated Show resolved Hide resolved
spec/fixtures/converters/two_records.json Outdated Show resolved Hide resolved
@postmodern postmodern merged commit dea3d33 into main Feb 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants