Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to work under Node.js v12 #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated to work under Node.js v12 #1

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67843b5
Updated nan to 2.14.0
vlasky Dec 16, 2019
49109da
Fixed Uint32Value() semantics
vlasky Dec 16, 2019
26a3c1b
Renamed fork to @vlasky/quoted-printable in preparation of NPM release.
vlasky Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ NAN_METHOD(decode) {
}
v8::Local<v8::Object> sourceHandle = info[0].As<v8::Object>();
v8::Local<v8::Object> targetHandle = info[1].As<v8::Object>();
const uint8_t qEncoding = info[2]->Uint32Value();
const uint8_t qEncoding = info[2]->Uint32Value(Nan::GetCurrentContext()).FromJust();
v8::Local<v8::Object> tableDecodingHandle = info[3].As<v8::Object>();
v8::Local<v8::Object> tableLegalHandle = info[4].As<v8::Object>();
const uint32_t sourceLength = node::Buffer::Length(sourceHandle);
Expand Down Expand Up @@ -216,7 +216,7 @@ NAN_METHOD(encode) {
}
v8::Local<v8::Object> sourceHandle = info[0].As<v8::Object>();
v8::Local<v8::Object> targetHandle = info[1].As<v8::Object>();
const uint8_t qEncoding = info[2]->Uint32Value();
const uint8_t qEncoding = info[2]->Uint32Value(Nan::GetCurrentContext()).FromJust();
v8::Local<v8::Object> tableEncodingHandle = info[3].As<v8::Object>();
v8::Local<v8::Object> tableLiteralsHandle = info[4].As<v8::Object>();
const uint32_t sourceLength = node::Buffer::Length(sourceHandle);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
},
"dependencies": {
"@ronomon/queue": "^3.0.0",
"nan": "^2.10.0"
"nan": "^2.14.0"
vlasky marked this conversation as resolved.
Show resolved Hide resolved
}
}