feat(rooch-da): enhance adapter with submit stat tracking #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `best_rollback` to use `print!` for consistent multiline log formatting. This ensures cleaner output and better readability of rollback details.
Add `AdapterSubmitStat` for tracking chunk/segment submission status. Integrated tracking logic into various DA backends and their adapters. Updated `DAServerActor` to report backend statuses with latest completed chunks.
Added comments to clarify its association with block numbers in the current ChunkV0 version.
Extend `DAInfoView` with an `avail_backends` field to include backend availability details. Updated `From<DAServerStatus>` impl to map the new field as part of the conversion.
popcnt1
requested review from
jolestar,
baichuan3,
wow-sven and
pause125
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Add a required `avail_backends` property to the `DAInfoView` schema. This property is an array of pairs (string and u128) and enforces a strict length of two items in each pair.
jolestar
reviewed
Jan 21, 2025
Clarified documentation for `avail_backends` to specify block number update behavior. Improved overall comment readability for better understanding.
jolestar
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
AdapterSubmitStatfor tracking chunk/segment submission status.Integrated tracking logic into various DA backends and their adapters.
Updated
DAServerActorto report backend statuses with latest completed chunksfeat(rooch-rpc-api): add
avail_backendsto DAInfoViewExtend
DAInfoViewwith anavail_backendsfield to include backend availability details. UpdatedFrom<DAServerStatus>impl to map the new field as part of the conversion"da_info" return by
rooch rpc request --method rooch_statuswill be:avail_backendsis added