This repository has been archived by the owner on Feb 12, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
AUTHORS.md
This removes the logging config from the init. Logging config is normally done by the end user, not the package itself ? I see logging stuff in
clisops
, so I'm guessing the config that was set here was overrided anyway in most cases ?In my case, this unwanted logging configuration was making my console spit way too much stuff that I don't need. More generally, our usecase of clisops is in workflows using xscen, where we take care of the logging configuration ourselves.
I also updated the
environment.yml
file that was missing a few dependencies present insetup.py
.I guess not. If yes, the removed line are exactly what I user would need to add to their code to retrieve the previous behaviour.