Skip to content
This repository has been archived by the owner on Feb 12, 2025. It is now read-only.

Fix logging and update conda env #115

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

aulemahal
Copy link
Contributor

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes issue #xyz
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • I have added my relevant user information to AUTHORS.md
  • What kind of change does this PR introduce?:
    This removes the logging config from the init. Logging config is normally done by the end user, not the package itself ? I see logging stuff in clisops, so I'm guessing the config that was set here was overrided anyway in most cases ?

In my case, this unwanted logging configuration was making my console spit way too much stuff that I don't need. More generally, our usecase of clisops is in workflows using xscen, where we take care of the logging configuration ourselves.

I also updated the environment.yml file that was missing a few dependencies present in setup.py.

  • Does this PR introduce a breaking change?:
    I guess not. If yes, the removed line are exactly what I user would need to add to their code to retrieve the previous behaviour.

@cehbrecht cehbrecht self-requested a review April 16, 2024 15:11
@cehbrecht cehbrecht merged commit 905ea49 into roocs:master Apr 16, 2024
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants