Skip to content

Commit

Permalink
Deletes automatic citation on load for 1.0.6
Browse files Browse the repository at this point in the history
  • Loading branch information
cimentadaj committed Jan 27, 2021
1 parent 0f1ac2c commit bfe2c45
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 61 deletions.
2 changes: 0 additions & 2 deletions CRAN-RELEASE

This file was deleted.

2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: essurvey
Title: Download Data from the European Social Survey on the Fly
Version: 1.0.5
Version: 1.0.6
Date: 2019-12-11
Authors@R: c(
person("Jorge", "Cimentada", email = "[email protected]", role = c("aut", "cre")),
Expand Down
8 changes: 7 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
## essurvey 1.0.6.9999
## essurvey 1.0.7.9999

## essurvey 1.0.6

- CRAN maintenance release to fix Solaris warnings `Warning in engine$weave(file, quiet = quiet, encoding = enc) : Pandoc (>= 1.12.3) and/or pandoc-citeproc not available. Falling back to R Markdown v1` on CRAN. Tested on Rhub and all passes OK, notifying CRAN.

- Removes automatic citation message when loading package. It's actually annoying.

## essurvey 1.0.5

Expand Down
7 changes: 0 additions & 7 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,6 @@ Note: The `essurvey` package was originally called `ess`. Since `essurvey 1.0.0`

The `essurvey` package is designed to download the ESS data as easily as possible. It has a few helper functions to download rounds (a term synonym to waves to denote the same survey in different time points), rounds for a selected country and to show which rounds/countries are available. Check out the vignette and other documentation in the [package's website](https://ropensci.github.io/essurvey/) for more detailed examples of the `essurvey` package.

## Citation

```{r echo = FALSE, eval = TRUE}
citation("essurvey")
```


## Installation

You can install and load the development version with these commands:
Expand Down
21 changes: 0 additions & 21 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,24 +34,6 @@ available. Check out the vignette and other documentation in the
[package’s website](https://ropensci.github.io/essurvey/) for more
detailed examples of the `essurvey` package.

## Citation

#>
#> To cite essurvey in publications use:
#>
#> Cimentada, Jorge (2019). Download Data from the European Social
#> Survey on the Fly R package version 1.0.3
#>
#> A BibTeX entry for LaTeX users is
#>
#> @Manual{,
#> title = {Download Data from the European Social Survey on the Fly},
#> author = {Jorge Cimentada},
#> year = {2019},
#> note = {R package version 1.0.3},
#> url = {https://docs.ropensci.org/essurvey/},
#> }

## Installation

You can install and load the development version with these commands:
Expand Down Expand Up @@ -86,9 +68,6 @@ To explore which rounds/countries are present in the ESS use the

``` r
library(essurvey)
#>
#> Please cite as:
#> Cimentada, Jorge (2019). Download Data from the European Social Survey on the Fly R package version 1.0.2.
show_countries()
#> [1] "Albania" "Austria" "Belgium"
#> [4] "Bulgaria" "Croatia" "Cyprus"
Expand Down
29 changes: 6 additions & 23 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,27 +13,10 @@ There are currently no downstream dependencies for this package.

---

Maintenance check excluding all examples/tests based on the comment from Brian
Ripley saying that "Packages which use Internet resources should fail gracefully
with an informative message if the resource is not available (and not give a
check warning nor error)".
Maintenance check for problem with Solaris warning saying that 'Warning in engine$weave(file, quiet = quiet, encoding = enc) :
Pandoc (>= 1.12.3) and/or pandoc-citeproc not available. Falling back to R Markdown v1'. This is what the CRAN checks
were saying https://www.r-project.org/nosvn/R.check/r-patched-solaris-x86/essurvey-00check.html yet this runs well on
Solaris in Rhub https://builder.r-hub.io/status/original/essurvey_1.0.5.tar.gz-843e084a807144a2acc95d9dcdc9acb0. Oddly,
this warning is only present in Solaris with all other platforms passing gracefully.

All tests are run weekly on Travis, which are available at https://travis-ci.org/ropensci/essurvey

- *All* examples are wrapped in \dontrun{} because they cannot be run
in < 5 seconds. No smaller toy examples can be created. Functions
which can be executed in < 5 are allow to run only if they don't
make any requests to internet resources. All tests/examples are run
on Travis/Appveyor

Also, most functions use personal emails to actually run. Even if using
\dontshow{} I wouldn’t want to reveal any information (either on Github or
somewhere on the CRAN repo) of personal use.

- The tests are wrapped skip_on_cran()
since they absolutely require using a private email. Full tests
are run on Travis (weekly) with results available for review:
https://travis-ci.org/ropensci/essurvey

The Travis tests have an environment variable containing the email. This
allows the tests to run smoothly.
All tests are run weekly on Travis, which are available at https://travis-ci.com/github/ropensci/essurvey
8 changes: 4 additions & 4 deletions man/import_rounds.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/import_sddf_country.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bfe2c45

Please sign in to comment.