return std::string instead of const ref as char * are returned by lif…

…ecycle node
ros-controls · Dec 31, 2024 · f201856 · f201856
1 parent 3838f45
commit f201856
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/controller_interface/include/controller_interface/controller_interface_base.hpp b/controller_interface/include/controller_interface/controller_interface_base.hpp
@@ -306,7 +306,7 @@ class ControllerInterfaceBase : public rclcpp_lifecycle::node_interfaces::Lifecy
    */
   void wait_for_trigger_update_to_finish();
 
-  const std::string & get_name() const;
+  std::string get_name() const;
 
   /// Enable or disable introspection of the controller.
   /**

diff --git a/controller_interface/src/controller_interface_base.cpp b/controller_interface/src/controller_interface_base.cpp
@@ -243,7 +243,7 @@ void ControllerInterfaceBase::wait_for_trigger_update_to_finish()
   }
 }
 
-const std::string & ControllerInterfaceBase::get_name() const { return get_node()->get_name(); }
+std::string ControllerInterfaceBase::get_name() const { return get_node()->get_name(); }
 
 void ControllerInterfaceBase::enable_introspection(bool enable)
 {
-Original file line number
+Diff line change
@@ Expand Up @@
       }
     }
-    const std::string & ControllerInterfaceBase::get_name() const { return get_node()->get_name(); }
+    std::string ControllerInterfaceBase::get_name() const { return get_node()->get_name(); }
     void ControllerInterfaceBase::enable_introspection(bool enable)
     {
@@ Expand Down @@