Add few warning compiler options to error #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1181 +/- ##
==========================================
- Coverage 47.63% 47.63% -0.01%
==========================================
Files 40 40
Lines 3445 3441 -4
Branches 1866 1864 -2
==========================================
- Hits 1641 1639 -2
Misses 480 480
+ Partials 1324 1322 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
reviewed
Nov 25, 2023
|
@Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2024
* add conversion, unused-but-set-variable, and return-type warnings to error * add shadow variables to error and their fixes for code compilation * apply the same flags to controller interface package * apply the same flags and their fixes to hardware_interface package * apply the same compiler options to the rest of the packages (cherry picked from commit 65353ff) # Conflicts: # controller_manager/src/controller_manager.cpp # hardware_interface_testing/test/test_resource_manager.cpp
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2024
* add conversion, unused-but-set-variable, and return-type warnings to error * add shadow variables to error and their fixes for code compilation * apply the same flags to controller interface package * apply the same flags and their fixes to hardware_interface package * apply the same compiler options to the rest of the packages (cherry picked from commit 65353ff) # Conflicts: # controller_interface/CMakeLists.txt # controller_manager/CMakeLists.txt # controller_manager/src/controller_manager.cpp # hardware_interface/CMakeLists.txt # hardware_interface_testing/test/test_resource_manager.cpp # joint_limits/CMakeLists.txt # transmission_interface/CMakeLists.txt
This was referenced Oct 26, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 26, 2024
* add conversion, unused-but-set-variable, and return-type warnings to error * add shadow variables to error and their fixes for code compilation * apply the same flags to controller interface package * apply the same flags and their fixes to hardware_interface package * apply the same compiler options to the rest of the packages
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 26, 2024
* add conversion, unused-but-set-variable, and return-type warnings to error * add shadow variables to error and their fixes for code compilation * apply the same flags to controller interface package * apply the same flags and their fixes to hardware_interface package * apply the same compiler options to the rest of the packages
christophfroehlich
added a commit
that referenced
this pull request
Oct 27, 2024
* Add few warning compiler options to error (#1181) * add conversion, unused-but-set-variable, and return-type warnings to error * add shadow variables to error and their fixes for code compilation * apply the same flags to controller interface package * apply the same flags and their fixes to hardware_interface package * apply the same compiler options to the rest of the packages * Deactivate compiler warning for class_loader --------- Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspiring from the PRs that @destogl made recently: #1173 & #1174. I think it is in the best interest of everyone to add some compiler flags to errors to better code quality. I have done it for the most important packages and fixed some errors at the same time