Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more parameter overriding tests from parsing multiple parameter files #1899

Conversation

saikishor
Copy link
Member

This PR just adds more tests to test the parameter overriding concepts more explicitly

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.83%. Comparing base (c9a0ab9) to head (900bfb2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
controller_manager/test/test_spawner_unspawner.cpp 82.50% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1899      +/-   ##
==========================================
- Coverage   87.85%   87.83%   -0.02%     
==========================================
  Files         121      121              
  Lines       12515    12555      +40     
  Branches     1124     1131       +7     
==========================================
+ Hits        10995    11028      +33     
  Misses       1108     1108              
- Partials      412      419       +7     
Flag Coverage Δ
unittests 87.83% <82.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/test/test_spawner_unspawner.cpp 97.31% <82.50%> (-1.79%) ⬇️

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unfortunately, the coverage metrics don't acknowledge your efforts :(

@saikishor
Copy link
Member Author

LGTM. Unfortunately, the coverage metrics don't acknowledge your efforts :(

Hahahhaa It happens XD

@saikishor saikishor enabled auto-merge (squash) November 29, 2024 12:12
@saikishor saikishor disabled auto-merge November 29, 2024 12:12
@saikishor saikishor merged commit 2b22d0c into ros-controls:master Nov 29, 2024
22 checks passed
@saikishor saikishor deleted the add/spawner/parameter/overriding/test branch November 29, 2024 12:12
@saikishor saikishor restored the add/spawner/parameter/overriding/test branch November 29, 2024 12:12
@saikishor saikishor deleted the add/spawner/parameter/overriding/test branch November 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants