-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using urdf/model.hpp for rolling #1978
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1978 +/- ##
==========================================
+ Coverage 89.21% 89.27% +0.05%
==========================================
Files 130 130
Lines 14495 14493 -2
Branches 1257 1257
==========================================
+ Hits 12932 12938 +6
+ Misses 1093 1088 -5
+ Partials 470 467 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nakul-py can you fix the pre-commit?. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rclcpp version constraint is to allow compilation on humble, correct?
and on jazzy as well. |
@nakul-py you can run pre-commit locally, see the message in the failing checks or the contributing guidelines, or the text in the good first issue
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nakul-py you are not supposed to touch the files of the pre-commit configuration. Please revert your last commit.
As @christophfroehlich mentioned, just run pre-commit run --all-files
and this should edit the files automatically and just commit the changes after running that command.
Hi @saikishor I have done that. Would this works fine af79849 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is fine now!
@nakul-py maybe you want to take ros-controls/ros2_controllers#1469 as well, because the same changes are needed there! |
Ok i will proceed. |
Description
This pull request addresses the use of the deprecated
urdf/model.h
header in component_parser.cpp to ensure compatibility with Rolling, Jazzy, and Humble distributions of ROS 2.Since
urdf/model.h
was replaced byurdf/model.hpp
in newer ROS 2 distributions starting from Rolling, this PR introduces a version-conditional include to maintain backward compatibility with older distributions.Fixes #1977