Trigger shutdown transition in destructor

[christophfroehlich]

Since ros2/rclcpp#2562 we get lots of warnings in the test logs like

[WARN] [1735845337.264023881] [rclcpp_lifecycle]: LifecycleNode is not shut down: Node still in state(1) in destructor

I think we can just trigger the shutdown transition in the destructor of the base class.

We still had some warnings in tests of this repo when rclcpp::shutdown() is called before the node is destructed, and the context is invalid. The transition then would fail without the rclcpp::ok() check.

[saikishor]

The changes look good to me

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.30%. Comparing base (6e1059c) to head (4ae7e79).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1979      +/-   ##
==========================================
+ Coverage   89.26%   89.30%   +0.04%     
==========================================
  Files         130      130              
  Lines       14493    14516      +23     
  Branches     1257     1258       +1     
==========================================
+ Hits        12937    12964      +27     
+ Misses       1088     1084       -4     
  Partials      468      468              

Flag	Coverage Δ
unittests	89.30% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...controller_interface/controller_interface_base.hpp	91.66% <ø> (-0.65%)	⬇️
...roller_interface/src/controller_interface_base.cpp	87.73% <100.00%> (+5.26%)	⬆️
...oller_interface/test/test_controller_interface.cpp	100.00% <100.00%> (ø)
...er_interface/test/test_controller_with_options.cpp	100.00% <100.00%> (ø)
joint_limits/test/joint_limits_rosparam_test.cpp	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[saikishor]

LGTM