Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing link of mock_components to hardware_interface (backport #1992) #1993

Closed
wants to merge 3 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 10, 2025

mock_components uses symbols defined in hardware_interface, but is not linking it. This is fine on ELF platforms where linker typically do not report errors is a symbols is undefined in a library, and the only important thing is that the symbols is eventually defined in the final linked executables, but on different platforms (like macOS or Windows) this missing link can create link errors.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

This is an automatic backport of pull request #1992 done by [Mergify](https://mergify.com).

(cherry picked from commit d501f1b)

# Conflicts:
#	hardware_interface/CMakeLists.txt
@mergify mergify bot added the conflicts label Jan 10, 2025
Copy link
Contributor Author

mergify bot commented Jan 10, 2025

Cherry-pick of d501f1b has failed:

On branch mergify/bp/humble/pr-1992
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit d501f1b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hardware_interface/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@christophfroehlich
Copy link
Contributor

Already included on humble.

@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1992 branch January 10, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants