Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update path of GPL includes #1994

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Update path of GPL includes #1994

merged 3 commits into from
Jan 15, 2025
+1 −1

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Jan 11, 2025
@christophfroehlich christophfroehlich marked this pull request as ready for review January 15, 2025 15:15
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.35%. Comparing base (751cd85) to head (92acd18).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1994      +/-   ##
==========================================
+ Coverage   89.32%   89.35%   +0.03%     
==========================================
  Files         130      130              
  Lines       14576    14575       -1     
  Branches     1258     1258              
==========================================
+ Hits        13020    13024       +4     
+ Misses       1090     1088       -2     
+ Partials      466      463       -3
Flag Coverage Δ
unittests 89.35% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 76.42% <ø> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

@christophfroehlich christophfroehlich merged commit f8c03cc into master Jan 15, 2025
23 of 25 checks passed
@christophfroehlich christophfroehlich deleted the update/gpl branch January 15, 2025 22:38
mergify bot pushed a commit that referenced this pull request Jan 15, 2025
@christophfroehlich @mergify
Update path of GPL (#1994)
c47de14 
(cherry picked from commit f8c03cc)

# Conflicts:
#	controller_manager/src/controller_manager.cpp
@mergify mergify bot mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

@homalozoa homalozoa Awaiting requested review from homalozoa

@mcbed mcbed Awaiting requested review from mcbed

@olivier-stasse olivier-stasse Awaiting requested review from olivier-stasse

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@qiayuanl qiayuanl Awaiting requested review from qiayuanl

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @saikishor