-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM] Add controller_manager activity topic #2006
base: master
Are you sure you want to change the base?
[CM] Add controller_manager activity topic #2006
Conversation
dbe3071
to
6768145
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2006 +/- ##
==========================================
+ Coverage 89.35% 89.37% +0.01%
==========================================
Files 130 130
Lines 14576 14640 +64
Branches 1258 1265 +7
==========================================
+ Hits 13024 13084 +60
+ Misses 1088 1085 -3
- Partials 464 471 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great addition. Should we also add a publisher section here describing this?
https://control.ros.org/rolling/doc/ros2_control/controller_manager/doc/userdoc.html#subscribers
Actually, I want to document all the Services and Publishers from the controller manager. I don't know if I have to do it in this PR or a separate PR. What's your opinion @christophfroehlich |
@@ -529,6 +543,8 @@ class ControllerManager : public rclcpp::Node | |||
int updated_controllers_index_ = 0; | |||
/// The index of the controllers list being used in the real-time thread. | |||
int used_by_realtime_controllers_index_ = -1; | |||
|
|||
std::function<void()> switch_callback_ = nullptr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to call it on_switch_callback_
instead?
please add the docs for this new publisher with this PR. |
As discussed in the ros2_control WG meeting on 15th Jan 2025
I've added a topic to the CM inorder to publish information on changes in the CM. This is quite useful to have when developing applications that need to be dynamic enough with the changes in CM. Right now, the only way is to spam the CM with lot of service requests.
It should look something like the below