Remove unstamped twist subscribers + parameters #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
destogl,
moriarty,
progtologist,
saikishor,
VanshGehlot and
VX792
This was referenced May 26, 2024
saikishor
requested changes
May 27, 2024
steering_controllers_library/src/steering_controllers_library.cpp
Outdated
Show resolved
Hide resolved
not minor, the deprecation note was in the wrong section anyways :D it was shown when the correct message type was used. |
Co-authored-by: Sai Kishor Kothakota <[email protected]>
christophfroehlich
force-pushed
the
remove_unstamped
branch
from
852d3b5 to
bfb8922
Compare
bmagyar
approved these changes
Jun 5, 2024
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
… can not be started because of a logical bug added when adding dynamics calculation functionality. (ros-controls#1151) Co-authored-by: Bence Magyar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the earlier already deprecated unstamped twist subscribers for tricycle controller and steering controllers library.
Closes #989