-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add now missing includes #1226
Add now missing includes #1226
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1226 +/- ##
==========================================
- Coverage 86.56% 86.55% -0.02%
==========================================
Files 95 95
Lines 8585 8586 +1
Branches 719 719
==========================================
Hits 7432 7432
Misses 883 883
- Partials 270 271 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
We have to recheck if the downstream packages are building or not with the changes from ros-controls/ros2_control#1627, if not we have to propagate the changes to downstream packages to avoid issues with the releases in ROS Buildfarm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a surprisingly small amount to what I expected from the OP ;) thank you!
ros-controls/ros2_control#1627 removed lots of unused dependencies in the upstream packages, but now lots of packages here fail because of missing includes.
IMHO this was bad practice, so I'll fix them here instead of reverting the upstream changes.
👀 @henrygerardmoore