Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_nodes: catch keyboard interrupt and add simple launch tests #1369

Merged
merged 5 commits into from
Nov 18, 2024

Fix parameter file

b0cbe8e
Select commit
Loading
Failed to load commit list.
Merged

test_nodes: catch keyboard interrupt and add simple launch tests #1369

Fix parameter file
b0cbe8e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 18, 2024 in 1s

82.57% (+1.09%) compared to 28dd7e1

View this Pull Request on Codecov

82.57% (+1.09%) compared to 28dd7e1

Details

Codecov Report

Attention: Patch coverage is 90.56604% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.57%. Comparing base (28dd7e1) to head (b0cbe8e).

Files with missing lines Patch % Lines
...est_nodes/publisher_forward_position_controller.py 44.44% 4 Missing and 1 partial ⚠️
...est_nodes/publisher_joint_trajectory_controller.py 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
+ Coverage   81.47%   82.57%   +1.09%     
==========================================
  Files         110      112       +2     
  Lines        9823     9920      +97     
  Branches      860      867       +7     
==========================================
+ Hits         8003     8191     +188     
+ Misses       1541     1438     -103     
- Partials      279      291      +12     
Files with missing lines Coverage Δ
ros2_controllers_test_nodes/setup.py 0.00% <ø> (ø)
...st_publisher_forward_position_controller_launch.py 100.00% <100.00%> (ø)
...st_publisher_joint_trajectory_controller_launch.py 100.00% <100.00%> (ø)
...est_nodes/publisher_forward_position_controller.py 80.00% <44.44%> (+80.00%) ⬆️
...est_nodes/publisher_joint_trajectory_controller.py 57.52% <44.44%> (+57.52%) ⬆️

... and 3 files with indirect coverage changes